1. Forum
  2. Fidonet
  3. SYNC PROGRAMMING

  • src/sbbs3/userdat.c

    From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Wednesday, December 17, 2025 19:09:19
    https://gitlab.synchro.net/main/sbbs/-/commit/5ccd9e8ccc6fd0158c7228b6
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix bug in subtract_cdt() handling free credit roll-under to regular credits

    Bug introduced in commit 8deac23222b3a3db (copy/paste/typo)

    Caught during manual code review.

    When a user has any amount of free credits, but the amount being subtracted
    was greater than their free credits available, the underflow was supposed to
    be deducted from their regular credits. Instead, the underflow was (attempted) to be deducted from their free credits, which were alreay zeroed.
    --- SBBSecho 3.33-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Saturday, December 20, 2025 04:34:42
    https://gitlab.synchro.net/main/sbbs/-/commit/a12a964a5ffbf5ab30e0fd8d
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Better user name/alias validity checking check_name() and check_realname()

    - detect/reject strings with control characters
    - detect/reject strings with non-ASCII character
    (when configured to do so by the sysop)

    Since the newuser.cpp already disallows this illegal input for new user values this likely only really makes a difference for any JS code that uses system.check_name() or system.check_realname() which is probably none.
    --- SBBSecho 3.33-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Friday, January 02, 2026 21:28:56
    https://gitlab.synchro.net/main/sbbs/-/commit/83a11c0359921d21e7b3b14e
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Add valid range enforcement in getbirthmonth() and getbirthday()

    This is required to pass the tests/user/birthdate.js tests/user/birthdate.
    --- SBBSecho 3.34-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Saturday, January 03, 2026 00:14:09
    https://gitlab.synchro.net/main/sbbs/-/commit/2b773f32ee03f5b95fcb026a
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Reject blank strings as an invalid birthdate
    --- SBBSecho 3.34-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Saturday, January 03, 2026 04:45:04
    https://gitlab.synchro.net/main/sbbs/-/commit/d3a398d76a1a224c6254b7f5
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix the begin/end with white space checks in check_name and check_realname

    char is signed (usually)

    This was rejected names that ended in extended-ASCII chars (when allowed)
    --- SBBSecho 3.34-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Tuesday, January 13, 2026 22:16:37
    https://gitlab.synchro.net/main/sbbs/-/commit/fe0ef584fb420831e37e4174
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Address new Coverity issue

    CID 640988: Null pointer dereferences (FORWARD_NULL)
    --- SBBSecho 3.34-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thursday, January 15, 2026 16:38:13
    https://gitlab.synchro.net/main/sbbs/-/commit/abf06be881e9b986937c72de
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix "executing xtrn" node_activity() for multiple-concurrent logons (Guests)

    The name of the external program was pulled from the user record which in this case would always be the last program executed by (any) Guest. Instead, use
    the (slightly more ambiguous) node.aux field for external program being executed by Guest users or upon any failure to read the user record.
    --- SBBSecho 3.34-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)